Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update push constant docs to reflect the API #2637

Merged
merged 2 commits into from
May 3, 2022
Merged

Update push constant docs to reflect the API #2637

merged 2 commits into from
May 3, 2022

Conversation

Noxime
Copy link
Contributor

@Noxime Noxime commented May 2, 2022

Alignment rules for push constant data are no longer enforced by using &[u32] as the input type, but the docs don't reflect that. This is a simple documentation fix to address it.

cwfitzgerald
cwfitzgerald approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cwfitzgerald
cwfitzgerald requested changes May 3, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh forgot, we actually need to change the docs on the compute passes too

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) May 3, 2022 04:50
@cwfitzgerald cwfitzgerald merged commit 51dbe23 into gfx-rs:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noxime @cwfitzgerald